Sune Foldager
2011-11-21 14:12:22 UTC
Greetings
I'd like to discuss a feature missing from thg which was in hgtk:
opening repos with added bundles.
In hgtk the workflow was as follows:
You typed: hgtk log -R bundle:path/to/bundle
and it opened up the log view, with the bundle displayed as incoming.
The syntax was somewhat more general, as you could provide the
repository path as well: bundle:path/to/bundle/:path/to/repo (if I recall).
This is missing from thg, and is a very important feature for us (my
work), since we use it to invoke thg from another tool, showing incoming
(or unbundled) changesets. I tried hacking it in by calling setBundle in
workbench.run, which sorta works (although unnecessarily creates extra
repo instances), but it could be done somewhat better I guess. I can
send in a patch, but are there any thoughts on how this should work?
After getting it to work, essentially like using the 'Unbundle' feature
in the sync section, I see another regression which I guess is by
design, but is a big showstopper for us:
When you view incoming changesets, you *can't* navigate to any other
changeset in the viewer. You can only click on the new ones, and the
other ones are grayed out. Previously, the new ones were marked up, and
everything otherwise worked as normal.
With repos our size and complexity, it's imperative that we can navigate
and view other changesets as part of a review process for incoming or
bundles ones. The highlight isn't the problem, really, but the lack of
navigation is. I suspect there is some reason for this, though, so I
would like to hear some thoughts.
-Sune
I'd like to discuss a feature missing from thg which was in hgtk:
opening repos with added bundles.
In hgtk the workflow was as follows:
You typed: hgtk log -R bundle:path/to/bundle
and it opened up the log view, with the bundle displayed as incoming.
The syntax was somewhat more general, as you could provide the
repository path as well: bundle:path/to/bundle/:path/to/repo (if I recall).
This is missing from thg, and is a very important feature for us (my
work), since we use it to invoke thg from another tool, showing incoming
(or unbundled) changesets. I tried hacking it in by calling setBundle in
workbench.run, which sorta works (although unnecessarily creates extra
repo instances), but it could be done somewhat better I guess. I can
send in a patch, but are there any thoughts on how this should work?
After getting it to work, essentially like using the 'Unbundle' feature
in the sync section, I see another regression which I guess is by
design, but is a big showstopper for us:
When you view incoming changesets, you *can't* navigate to any other
changeset in the viewer. You can only click on the new ones, and the
other ones are grayed out. Previously, the new ones were marked up, and
everything otherwise worked as normal.
With repos our size and complexity, it's imperative that we can navigate
and view other changesets as part of a review process for incoming or
bundles ones. The highlight isn't the problem, really, but the lack of
navigation is. I suspect there is some reason for this, though, so I
would like to hear some thoughts.
-Sune